Skip to content

fix(nav): keep desktop side nav visible under the user panel backdrop#428

Merged
spe1020 merged 2 commits into
zapcooking:mainfrom
dmnyc:fix/sidenav-visible-under-user-panel
Jun 11, 2026
Merged

fix(nav): keep desktop side nav visible under the user panel backdrop#428
spe1020 merged 2 commits into
zapcooking:mainfrom
dmnyc:fix/sidenav-visible-under-user-panel

Conversation

@dmnyc

@dmnyc dmnyc commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes #426.

Problem

On desktop, opening the right-side user menu made the left side nav and logo vanish completely — the backdrop's dim/blur read as a solid wall over the left column.

Root cause

DesktopSideNav faded itself to opacity-0 + pointer-events-none whenever userSidePanelOpen was set (introduced in f7b488c, the unified-messaging commit). So the nav wasn't merely dimmed by the backdrop — it was removed outright, and the blur showed the feed content behind where it used to be.

Fix

  • Remove the self-fade. The nav stays in place at its normal z-index and gets dimmed + blurred by the panel's backdrop uniformly with the rest of the page — the menu and logo remain discernible through the frost, with no hard edges or special-cased regions.
  • UserSidePanel now also closes itself on afterNavigate as a safeguard, so the panel can never linger over a new page after navigation.

Test plan

  • Desktop (≥1280px): open the avatar menu — left nav + logo visible through the uniform dim/blur (matching the rest of the page) instead of disappearing
  • Click the dimmed area — panel closes (click-outside unchanged)
  • Mobile width: behavior unchanged (side nav is hidden below xl anyway)
  • Regular modals unaffected (nav z-index untouched at z-10)

The desktop side nav faded itself to opacity-0 whenever the user side
panel opened, so the panel's full-viewport dim/blur backdrop read as a
solid wall over the left column — menu and logo completely gone
(zapcooking#426). The fade came in with the unified-messaging commit (f7b488c).

Drop the fade: the nav now stays in place and is dimmed and blurred by
the backdrop uniformly with the rest of the page, so the menu and logo
remain discernible through the frost. Also close the panel on
afterNavigate as a safeguard so it never lingers across a page change.

Fixes zapcooking#426
@spe1020 spe1020 merged commit 161e3b6 into zapcooking:main Jun 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug (desktop): Left side menu and logo obscured when right side user menu is open

2 participants