fix(nav): keep desktop side nav visible under the user panel backdrop#428
Merged
spe1020 merged 2 commits intoJun 11, 2026
Merged
Conversation
The desktop side nav faded itself to opacity-0 whenever the user side panel opened, so the panel's full-viewport dim/blur backdrop read as a solid wall over the left column — menu and logo completely gone (zapcooking#426). The fade came in with the unified-messaging commit (f7b488c). Drop the fade: the nav now stays in place and is dimmed and blurred by the backdrop uniformly with the rest of the page, so the menu and logo remain discernible through the frost. Also close the panel on afterNavigate as a safeguard so it never lingers across a page change. Fixes zapcooking#426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426.
Problem
On desktop, opening the right-side user menu made the left side nav and logo vanish completely — the backdrop's dim/blur read as a solid wall over the left column.
Root cause
DesktopSideNavfaded itself toopacity-0+pointer-events-nonewheneveruserSidePanelOpenwas set (introduced in f7b488c, the unified-messaging commit). So the nav wasn't merely dimmed by the backdrop — it was removed outright, and the blur showed the feed content behind where it used to be.Fix
UserSidePanelnow also closes itself onafterNavigateas a safeguard, so the panel can never linger over a new page after navigation.Test plan