Accessibility enhancement on styles#5795
Conversation
… disable all animations
|
Thanks for working on accessibility improvements, @evnchn -- this is a valuable area that deserves attention. However, this PR has a few structural issues that make it hard to review and merge as-is: Merge conflicts after website redesign (#5910) The website was completely redesigned and merged in #5910. This PR touches 9 website files ( Too many concerns in a single PR This PR bundles at least 5 independent changes:
Each of these deserves its own review and discussion. Mixing a public API change with website styling tweaks makes it hard to evaluate the trade-offs individually. PR description lacks detail The description says "This PR focuses on the styles" and "The PR comments should be descriptive of the changes," but there is no explanation of what the changes are, why each one is needed, or what accessibility standards they address (WCAG level, specific success criteria, etc.). For a public API addition like "Help wanted" tag is unclear The PR is tagged as "help wanted" but doesn't specify what kind of help is needed -- code review? Testing with assistive technology? Completing the documentation mentioned in the checklist? This makes it hard for contributors to know how to pitch in. Suggestion Given the conflicts and the breadth of changes, it would probably make sense to split this into focused follow-ups:
This way each change can be reviewed on its own merits and merged independently. |
|
@falkoschindler I guess we're familiar with the situation as it's appearing several times:
And somewhere we'd meet in between. So that's kinda expected. However the twist comes when we realize that for the documentation page that accessibility is evolving backwards. And I don't blame the website design. It's a good one. It's just that IMHO modern design is somehow against accessibility without us realizing it, such as:
And that, hot take, "modern" = "average in the modern era", where let's be honest, = "poor accessibility". It compounds with the use of AI, which is the ultimate average-finding machine. Anyways, since the web design is out only a while, I'd think we can wait a while before shipping big changes, both to keep 3.10 sane, and to observe community feedback. Hence I would do PR 1 first, and PR 2 and 3 later. P.S.: If you have accessibility needs and the new documentation webpage is not good, then please comment below. I'll iterate with you, and keep the branch up to date so that you can view the documentation nicely 😉 |
|
Thanks for the thoughtful reply, @evnchn. You're right that modern design and accessibility often pull in opposite directions - that's a tension worth addressing. But I want to pick up on something you said: "I guess we're familiar with the situation as it's appearing several times." That's exactly the pattern I'd like us to break. What keeps happening is:
This is frustrating for everyone - you put in real effort and it goes stale before we can act on it. The lesson I take from this is that we need to keep the number of open PRs small and focused. Fewer concurrent PRs means shorter response times on our side, fewer topics to juggle in parallel, and a much lower chance of conflicts making work obsolete. A single-purpose PR with a clear description ("adds X because Y") is far easier to review quickly than a broad one that touches multiple concerns. So yes - let's start with the |
|
@falkoschindler I'm sleeping soon, but few points:
I think we'd meet in the middle for how we work as well, because I (and possibly others, and maybe the AI I use after following me so long) prefers to work top-down instead of bottom up. I like to answer "How might we XXX" more than "What fundamental building blocks are required to do XXX". Though both solve XXX I think you get the difference. For now I'd suggest:
Bottom line being, Yes to "breaking the pattern", sorry but no to eliminating project stretch PRs altogether, as no projects = no innovation = no upstream-ready PRs, because downstream's where the party's at. They need to exist but we need to make it work nicely. |
Motivation
As mentioned in #5794, we can do better in accessibility.
This PR focuses on the styles.
Implementation
Manually-written because I cannot trust an AI on human accessibility.
The PR comments should be descriptive of the changes.
The policy is: Implement the change in library-level if possible, if not then at documentation-website-level.
Progress
ui.colors(..., at_rule='@media (prefers-contrast: more)'), and general guidance, especially theforced-colors:variant.ui.skip_to_main: skip to main content button #5790 as wellFinal notes
Happy Lunar New Year everyone!