Cut header and tree visual effects for mobile#5824
Open
evnchn wants to merge 2 commits intozauberzeug:mainfrom
Open
Cut header and tree visual effects for mobile#5824evnchn wants to merge 2 commits intozauberzeug:mainfrom
evnchn wants to merge 2 commits intozauberzeug:mainfrom
Conversation
Collaborator
Author
|
About 50% faster, if we consider the Performance Monitor tab |
Replace CSS media query hack for nav tree with `:no-transition` prop bound to `Quasar.Screen.lt.md`, and add conditional fade/scale transitions on the search dialog based on viewport width. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
Collaborator
Author
|
Also according to https://pagespeed.web.dev/analysis/https-nicegui-io/li5rniz6jo?hl=en_GB&form_factor=mobile, the header padding is a "non-composited animation" and we best avoid it. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
While good INP is strongly desired for SEO purposes, the approach at #5801 is hacky, to say the least.
Are there any lower-hanging fruits before we go the nuclear option?
Implementation
I spotted 4 places for optimization:
fadetransition on mobile (viaQuasar.Screen.lt.md) instead of the default scale animation, reducing compositing work.While the network bottleneck is still there, we do everything in our power to ensure the CPU load is relieved as much as possible.
As we need only to shave 11ms for
https://nicegui.io/documentation/section_*we might just have a win for that. For the others 39ms is needed, and I am not super hopeful on that.Progress