Add set/get shape to body interface.#21
Closed
OndraVoves wants to merge 1 commit intozig-gamedev:mainfrom
Closed
Conversation
Author
|
Ouch duplicate of #19 |
Member
|
Merged #19 |
There was a problem hiding this comment.
Pull request overview
This pull request adds getShape and setShape methods to the body interface, allowing users to retrieve and update the shape of a physics body at runtime. These methods are exposed through the Zig API with corresponding C bindings.
Changes:
- Added
getShapeandsetShapefunctions to theBodyInterfacein the Zig bindings - Declared corresponding C API functions in the JoltPhysicsC header
- Implemented the C wrapper functions in JoltPhysicsC.cpp
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/zphysics.zig | Added getShape and setShape methods to BodyInterface with proper type casting and parameter handling |
| libs/JoltC/JoltPhysicsC.h | Declared C API function signatures for JPC_BodyInterface_GetShape and JPC_BodyInterface_SetShape |
| libs/JoltC/JoltPhysicsC.cpp | Implemented C wrapper functions to bridge between C API and underlying C++ Jolt Physics library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.