Fix: make AllowedDOFs non-exhaustive to support bitmasking#24
Merged
hazeycode merged 1 commit intozig-gamedev:mainfrom Feb 11, 2026
Merged
Fix: make AllowedDOFs non-exhaustive to support bitmasking#24hazeycode merged 1 commit intozig-gamedev:mainfrom
hazeycode merged 1 commit intozig-gamedev:mainfrom
Conversation
The current implementation uses an exhaustive enum which prevents bitwise
combinations. Combining flags results in values (like 23) that don't have
a matching tag, causing a compile error:
> error: enum 'zphysics.AllowedDOFs' has no tag with value '23'
Fixed by adding `_,` to the enum definition to make it non-exhaustive,
allowing arbitrary bitmask combinations.
Example usage:
```zig
BodyInterface.createAndAddBody(.{
.allowed_DOFs = @enumFromInt(
@intFromEnum(zphy.AllowedDOFs.translation_x) |
@intFromEnum(zphy.AllowedDOFs.translation_y) |
@intFromEnum(zphy.AllowedDOFs.translation_z) |
@intFromEnum(zphy.AllowedDOFs.rotation_y)
}, ...)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses an exhaustive enum which prevents bitwise combinations. Combining flags results in values (like 23) that don't have a matching tag, causing a compile error:
Fixed by adding
_,to the enum definition to make it non-exhaustive, allowing arbitrary bitmask combinations.Example usage: