Move Zemismart ZM25R3 _TZE200_sq6affpe to V2 cover quirk with correct DPs#4802
Open
Move Zemismart ZM25R3 _TZE200_sq6affpe to V2 cover quirk with correct DPs#4802
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4802 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 379 379
Lines 12745 12745
=======================================
Hits 11809 11809
Misses 936 936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Moves the Zemismart ZM25R3 (_TZE200_sq6affpe / TS0601) from a legacy (v1) TS0601 cover quirk to an existing v2 TuyaQuirkBuilder definition that uses the correct Tuya datapoints for position control/state.
Changes:
- Removed
_TZE200_sq6affpefrom the v1TuyaZemismartSmartCover0601_3MODELS_INFOmatch list. - Added
_TZE200_sq6affpeto the existing v2_TZE284_3mzb0sdzcover builder via.applies_to(...).
…ct DPs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
TheJulianJES
left a comment
There was a problem hiding this comment.
From a quick look, it does seem like there are some differences in Z2M between these models:
- Previous model: https://github.com/Koenkk/zigbee-herdsman-converters/blob/40f9a4298695a289fda4f246c99778b7de70e452/src/devices/zemismart.ts#L966-L999
- New model (this PR): https://github.com/Koenkk/zigbee-herdsman-converters/blob/40f9a4298695a289fda4f246c99778b7de70e452/src/devices/zemismart.ts#L87-L122
But you can confirm that everything is fully working? Enums? Border stuff etc.?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Move
_TZE200_sq6affpe(Zemismart ZM25R3) from the V1TuyaZemismartSmartCover0601_3class to the V2_TZE284_3mzb0sdzbuilder viaapplies_to.The V1 class used DPs 2/3 for position, but the actual device uses DPs 8/9 (confirmed via Koenkk/zigbee-herdsman-converters#9803). This meant position control was non-functional. The V2 builder from #4779 already has the correct DP mapping, so this PR simply adds the
_TZE200_sq6affpemanufacturer ID to it, gaining:Additional information
Tested on a physical Zemismart ZM25R3 device running on HA 2026.2.3 with a custom quirk using the same DP mappings. Open/close/stop, position slider, position inversion, and battery reporting all confirmed working.
This is a fix for existing users of
_TZE200_sq6affpewhose position control was broken under the V1 quirk.Checklist
pre-commitchecks pass / the code has been formatted using Black