Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4814 +/- ##
==========================================
+ Coverage 92.66% 92.84% +0.18%
==========================================
Files 380 380
Lines 12766 12755 -11
==========================================
+ Hits 11829 11842 +13
+ Misses 937 913 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR introduces "scene mode" support for the Xiaomi Cube device, allowing it to correctly emit ZHA events for physical actions. Additionally, I have refactored and tidied up the existing logic within the base quirk to improve readability and maintainability.
Additional information
The cube device has 2 modes: Gesture, and Scene. In Gesture mode, only certain gestures (e.g. flipping) become events. In scene mode it simply records which face is up. However for the purpose of the quirks, it can simply forward on any message it receives.
I removed the "description" field in the event as it implied the event know which orientation the cube was in, which it doesn't!
pre-commitchecks pass / the code has been formatted using Black