Add EpsilonRT DIY pilot wire module quirk#4827
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new v2 quirk for the EpsilonRT DIY pilot wire heating module (ERT-MPZ-03), closely following the existing NodOn pilot wire quirk pattern with identical enum values and cluster structure.
Changes:
- New manufacturer-specific cluster (
0xFC00) and enum for 6 pilot wire modes - V2 QuirkBuilder registration exposing the pilot wire mode as a select entity
- Basic tests for cluster and enum definitions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zhaquirks/epsilonrt/init.py | New package init for EpsilonRT manufacturer |
| zhaquirks/epsilonrt/pilot_wire.py | Custom cluster, enum, and v2 quirk for pilot wire module |
| tests/test_epsilonrt.py | Tests for cluster and enum definitions |
You can also share your feedback on Copilot code review. Take the survey.
d5ac7ee to
c69677d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4827 +/- ##
==========================================
+ Coverage 92.74% 92.75% +0.01%
==========================================
Files 382 383 +1
Lines 12783 12806 +23
==========================================
+ Hits 11855 11878 +23
Misses 928 928 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new v2 quirk for the EpsilonRT DIY Pilot Wire heating module (ERT-MPZ-03), closely following the existing Nodon pilot wire quirk pattern.
Changes:
- New manufacturer-specific cluster (
0xFC00) and enum for 6 pilot wire modes - Declarative v2 quirk registration with
QuirkBuilder - Basic tests for cluster attributes and enum values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
zhaquirks/epsilonrt/__init__.py |
New package init for EpsilonRT manufacturer |
zhaquirks/epsilonrt/pilot_wire.py |
Pilot wire cluster, enum, and quirk registration mirroring Nodon's implementation |
tests/test_epsilonrt.py |
Tests for cluster attribute definitions and enum values |
You can also share your feedback on Copilot code review. Take the survey.
Proposed change
This PR adds a new quirk for the EpsilonRT DIY Pilot Wire heating module (Model:
ERT-MPZ-03).The quirk implements a manufacturer-specific cluster (
0xFC00) to manage the 6 standard pilot wire modes. It follows the existing implementation patterns for French pilot wire modules (like Nodon) by using PascalCase for the Enum states to ensure immediate compatibility with current ZHA and Home Assistant versions.Additional information
0x1234.pilot_wire_modetranslation key for seamless integration.Device diagnostics
zha-01K8ZVXHG121GK60Z1SXFF0QAY-EpsilonRT ERT-MPZ-03-1b98d0483970a0c72e98f9e9a6ef208b.json
Checklist
pre-commitchecks pass / the code has been formatted using Black