AIP-9672: Add resourceRetryStrategy for quota-aware retries#8
Merged
abdulazillow merged 1 commit intofeature/zgfrom Oct 8, 2025
Merged
Conversation
- Add ResourceRetryStrategy field to Trigger struct - Implement error classification for resource constraint errors - Add DoWithResourceAwareRetry function for intelligent retry selection - Update sensor listener to use resource-aware retry logic - Add comprehensive test coverage for new functionality - Generate updated deepcopy code for new field
dhanashritidke11
approved these changes
Oct 7, 2025
Collaborator
dhanashritidke11
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for sharing the test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
ResourceRetryStrategyfield to Trigger struct enabling different retry behaviors for ResourceQuota errors vs regular validation errors. When resourceRetryStrategy is configured, quota-related errors (e.g., "exceeded quota") use the specified retry strategy while other errors use the default retryStrategy.Configuration
Sensors can now configure separate retry strategies for resource constraint errors:
Backward Compatibility
Maintains full backward compatibility - existing sensors continue working unchanged, while new sensors can opt into quota-aware retries. When resourceRetryStrategy is not specified, all errors use the default retryStrategy.
Test Results
Successfully tested in sandbox environment with actual ResourceQuota limits:
All tests validate correct retry strategy selection and maintain backward compatibility.