Skip to content

Bugfix: compatible schemas not properly handled during deserialization #25

Merged
stewartboyd119 merged 32 commits intomainfrom
bugfix/compatible-schemas-not-properly-handled
Feb 13, 2025
Merged

Bugfix: compatible schemas not properly handled during deserialization #25
stewartboyd119 merged 32 commits intomainfrom
bugfix/compatible-schemas-not-properly-handled

Conversation

@stewartboyd119
Copy link
Member

Forward/Backwards compatible schemas used to produce/consume messages were not being properly deserialized. Test_SchemaRegistryReal_Avro_AutoRegisterSchemas_OldProducerCanBeConsumedByNewConsumer and Test_SchemaRegistryReal_Avro_AutoRegisterSchemas_NewProducerCanBeConsumedByOldConsumer demonstrated bug. Schema registry aware avro formatter was updated to reconcile the bug.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (753a8aa) to head (60db9e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
formatter.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   88.58%   88.60%   +0.01%     
==========================================
  Files          18       18              
  Lines        1936     1939       +3     
==========================================
+ Hits         1715     1718       +3     
+ Misses        164      163       -1     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 merged commit 62f383c into main Feb 13, 2025
3 of 4 checks passed
@stewartboyd119 stewartboyd119 deleted the bugfix/compatible-schemas-not-properly-handled branch February 13, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants