Skip to content

Rmpmp-995: Updated dependencies and improved error messages when missing topic#29

Merged
stewartboyd119 merged 11 commits intomainfrom
rmpmp-995
Jun 30, 2025
Merged

Rmpmp-995: Updated dependencies and improved error messages when missing topic#29
stewartboyd119 merged 11 commits intomainfrom
rmpmp-995

Conversation

@stewartboyd119
Copy link
Member

@stewartboyd119 stewartboyd119 commented Jun 26, 2025

Rmpmp-995: Updated dependencies and improved error messages when missing topic name

The work loop uses a clientProvider.Reader() to get reader. The clientProvider implementation of this method only returns an error during misconfiguration. This is a permanent error and can't be recovered. Work has been updated to mark Reader() error as permanent and exit the work loop and return error.

Other changes:

  1. recoverThenFail() were added in all zkafka tests. The reason being, the use of containerized brokers during testing can lead to fragile test behavior (seg faults have been observed from librdkafka). By recovering in the tests, this can be better debugged since the entire test suite doesn't fail.

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (5c5c33b) to head (a2be9c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   88.61%   88.07%   -0.55%     
==========================================
  Files          18       18              
  Lines        1942     1954      +12     
==========================================
  Hits         1721     1721              
- Misses        164      173       +9     
- Partials       57       60       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stewartboyd119 stewartboyd119 merged commit ccc9efc into main Jun 30, 2025
3 of 4 checks passed
@stewartboyd119 stewartboyd119 deleted the rmpmp-995 branch June 30, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants