feat: add JsonPatch structure and unit tests#993
Open
akshayabogoju-coder wants to merge 4 commits intozio:mainfrom
Open
feat: add JsonPatch structure and unit tests#993akshayabogoju-coder wants to merge 4 commits intozio:mainfrom
akshayabogoju-coder wants to merge 4 commits intozio:mainfrom
Conversation
|
|
akshayabogoju-coder
force-pushed
the
main
branch
6 times, most recently
from
0c34d96 to
d31bcaf
Compare
akshayabogoju-coder
force-pushed
the
main
branch
from
d31bcaf to
7a0ce58
Compare
Author
|
All checks are passing now. I have fixed the linting and import order issues. Ready for review! @kitlangton @adamgfraser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Initial implementation of
JsonPatchforzio-schema-jsonto support basic record manipulation viaDynamicValue.Changes
JsonPatchsealed trait withAddandRemoveoperations forDynamicValue.Record.-Xfatal-warningsby explicitly defining return types and handling parameters to ensure Scala 3 migration compatibility.ListMapusage to maintain field ordering, consistent with ZIO Schema's internal record representation.Verification
sbt "zioSchemaJsonJVM / compile"— Success (0 warnings).sbt "zioSchemaJsonJVM / test"— 290 tests passed, 0 failed.JsonPatchSpecexecutes correctly with no regressions.All checks passed locally. Ready for review and merge. ✅
