fix: tolerate string amr claims from external providers#855
Merged
wim07101993 merged 4 commits intozitadel:mainfrom Apr 10, 2026
Merged
fix: tolerate string amr claims from external providers#855wim07101993 merged 4 commits intozitadel:mainfrom
wim07101993 merged 4 commits intozitadel:mainfrom
Conversation
Member
|
Couln't we handle this in the same way we do See |
Contributor
Author
Adjusted! |
wim07101993
approved these changes
Apr 10, 2026
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in Product Management
|
🎉 This PR is included in version 3.47.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amrvalues when providers return a single string instead of an arrayamrto[]stringfor ID token, access token, and introspection unmarshalling without changing the public field typesamrvalues during JSON unmarshallingTesting
go test ./pkg/oidcgo test ./...(currently fails in unrelated existing example/server route tests inpkg/client/rpandpkg/opunder Go 1.26 in this environment)