Open
Conversation
Contributor
Author
zloirock
reviewed
Apr 9, 2026
Contributor
Author
|
For now, I’ve only addressed the app crash issue. I’ll update the code shortly with improvements that more closely align with the intended purpose of |
Refactor NullProtoObjectViaActiveX and add error handling for 32-bit MSScriptControl.
Contributor
Author
|
On 32-bit systems only (64-bit is not supported), there is a way to obtain a fresh If we cannot give up null-prototype objects, using the |
Contributor
Author
|
I have added a fallback for 64-bit systems. |
Modify error handling to return an empty object if ScriptControl is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code forces the invocation of the
htmlfilemodule even in the WSH environment, which can cause crashes on machines where calling thehtmlfilemodule is restricted (e.g., due to unknown changes in IE-related settings).In the case of WSH (or
non-browser ES3 environment), its usage differs significantly from that of IE (as it is a standalone runtime rather than a web browser), so there is no real need to invoke thehtmlfilemodule. The issue can be resolved by not callinghtmlfileat all in the WSH environment.The related issue is as follows: