make packet.read unsafe and add a safe api in input context.#261
Open
nrbnlulu wants to merge 3 commits intozmwangx:masterfrom
Open
make packet.read unsafe and add a safe api in input context.#261nrbnlulu wants to merge 3 commits intozmwangx:masterfrom
nrbnlulu wants to merge 3 commits intozmwangx:masterfrom
Conversation
nrbnlulu
commented
Feb 4, 2026
|
|
||
| loop { | ||
| match packet.read(self.context) { | ||
| match unsafe { packet.read(self.context) } { |
Author
There was a problem hiding this comment.
I never used the iterator API tho if I had to guess I'd this can leak as well..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #260