Skip to content

feat: Enables payment sharing via intents (text / image)#1992

Open
tzarebczan wants to merge 1 commit into
zodl-inc:mainfrom
tzarebczan:send-to-target
Open

feat: Enables payment sharing via intents (text / image)#1992
tzarebczan wants to merge 1 commit into
zodl-inc:mainfrom
tzarebczan:send-to-target

Conversation

@tzarebczan

@tzarebczan tzarebczan commented Nov 19, 2025

Copy link
Copy Markdown

Motivation: I got tired of having to take a screenshot, then having to manually open Zodl, go to send, select image, and navigate to the screenshot.

This PR adds the ability to share payment requests via SEND intents which make the app a sharable target, including text (e.g. a zcash address, or zcash: uri and images containing QR codes.

This still maintains the third-party app detection for VIEW intents.

Tried looking at adding some tests, but the new code reuses existing scan/ZIP‑321/address validators and that there were no existing tests for those paths to update. I can follow up with another attempt should it be required.

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review your own code in GitHub's web interface1
  • Add automated tests as appropriate
  • Update the manual tests2 as appropriate
  • Check the code coverage3 report for the automated tests
  • Update documentation as appropriate (e.g README.md, Architecture.md, CHANGELOG.md, etc.)
  • Run the app and try the changes
  • Pull in the latest changes from the main branch and squash your commits before assigning a reviewer4

Note
It is good practice to provide before and after UI screenshots in the description of this PR. This is only applicable for changes that modify the UI.

Reviewer

  • Check the code with the Code Review Guidelines checklist
  • Perform an ad hoc review5
  • Review the automated tests
  • Review the manual tests
  • Review the documentation, README.md, Architecture.md, etc. as appropriate
  • Run the app and try the changes6

Footnotes

  1. Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.

  2. While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.

  3. While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.

  4. Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

  5. In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.

  6. While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

@tzarebczan
tzarebczan force-pushed the send-to-target branch 2 times, most recently from ff98fc5 to 9547b55 Compare November 24, 2025 15:20
@tzarebczan

Copy link
Copy Markdown
Author

Rebased my PR on master, would be awesome to still get this feature in. Would enable much easier ingestion of QR/shared addresses/payment links.

@tzarebczan

Copy link
Copy Markdown
Author

Any interest in this feature? Should be fairly safe and would be a great UX improvement around payments.

Happy to rebase and fix any issues based on feedback.

Adds the ability to share payment requests via SEND intents which make the app a sharable target, including text and images containing QR codes.

This still maintains the thirdparty app detection for VIEW intents.

Adds share target manual tests
@tzarebczan

Copy link
Copy Markdown
Author

Force pushed up the rebase, will check again after Ironwood stuff clears out - best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants