feat: Enables payment sharing via intents (text / image)#1992
Open
tzarebczan wants to merge 1 commit into
Open
feat: Enables payment sharing via intents (text / image)#1992tzarebczan wants to merge 1 commit into
tzarebczan wants to merge 1 commit into
Conversation
tzarebczan
force-pushed
the
send-to-target
branch
2 times, most recently
from
November 24, 2025 15:20
ff98fc5 to
9547b55
Compare
tzarebczan
force-pushed
the
send-to-target
branch
from
December 5, 2025 18:56
9547b55 to
99a47e7
Compare
Otr437
approved these changes
Dec 5, 2025
tzarebczan
force-pushed
the
send-to-target
branch
from
April 3, 2026 15:51
99a47e7 to
49ea412
Compare
Author
|
Rebased my PR on master, would be awesome to still get this feature in. Would enable much easier ingestion of QR/shared addresses/payment links. |
Author
|
Any interest in this feature? Should be fairly safe and would be a great UX improvement around payments. Happy to rebase and fix any issues based on feedback. |
Adds the ability to share payment requests via SEND intents which make the app a sharable target, including text and images containing QR codes. This still maintains the thirdparty app detection for VIEW intents. Adds share target manual tests
tzarebczan
force-pushed
the
send-to-target
branch
from
July 19, 2026 03:28
49ea412 to
a9bd673
Compare
Author
|
Force pushed up the rebase, will check again after Ironwood stuff clears out - best of luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: I got tired of having to take a screenshot, then having to manually open Zodl, go to send, select image, and navigate to the screenshot.
This PR adds the ability to share payment requests via SEND intents which make the app a sharable target, including text (e.g. a zcash address, or zcash: uri and images containing QR codes.
This still maintains the third-party app detection for VIEW intents.
Tried looking at adding some tests, but the new code reuses existing scan/ZIP‑321/address validators and that there were no existing tests for those paths to update. I can follow up with another attempt should it be required.
Author
Reviewer
Footnotes
Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs. ↩
While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down. ↩
While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with:
./gradlew checkfor Kotlin modules and./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=truefor Android modules. ↩Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit. ↩
In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass. ↩
While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally. ↩