Skip to content

Conversation

@feiyax
Copy link

@feiyax feiyax commented Aug 22, 2019

This change helps cases where a string starts with a quotation but without a quotation at its end in non-strict mode.

With this change, a string will end upon encountering unescaped quotation mark or unescaped line feed.


Without this change, the JSMN behaves inconsistently for such cases in non-strict mode, as explained below.

  • If the unterminated string is not the last of an object or array, JSMN will continue to treat everything as part of the string even include unescaped line feed (until it sees the leading quotation mark of the next either array element or object key).

  • If the unterminated string is the last of an object or array, JSMN returns error -3 JSMN_ERROR_PART immediately


I used the following json snippets to test before and after this change.

{
    "first": "good",
    "middle": "bad
    "last": "good"
}
{
    "first": "good",
    "middle": "good",
    "last": "bad
}

(please go easy on me; this is my first PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant