Automation side panel: 480px default width + resizable#18460
Automation side panel: 480px default width + resizable#18460
Conversation
This reverts commit f52d261.
|
@cubic-dev-ai review |
@melohagan I have started the AI code review. It will take a few minutes to complete. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa2b85d71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 3/5
- There is a concrete regression risk in
packages/builder/src/components/common/resizable.ts: double-click reset can now set size to0pxwheninitialValueis missing, which may collapse panels unexpectedly for users. - I’m scoring this as moderate risk because the issue is user-facing behavior (severity 6/10, high confidence 9/10), even though it appears localized to resize/reset logic.
- Pay close attention to
packages/builder/src/components/common/resizable.ts- reset behavior should restore default CSS sizing rather than forcing collapsed dimensions.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/builder/src/components/common/resizable.ts">
<violation number="1" location="packages/builder/src/components/common/resizable.ts:126">
P2: Double-click reset now forces `0px` when no `initialValue` is provided, which can collapse panels instead of restoring their default CSS size.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
…click" This reverts commit 69b18b4.
| Each commit requires permission. | ||
|
|
||
| Never auto-push changes unless explicitly asked to do so. You may ask permission to push. | ||
| Each push requires permission. |
| {/if} | ||
|
|
||
| <div class="content"> | ||
| {#if usePanel} |
| onMount(() => { | ||
| updateMaxWidth() | ||
| loadWidth() | ||
| window.addEventListener("resize", updateMaxWidth) |
There was a problem hiding this comment.
ahve you perf benched this? does it need deboucing / throttling?
| const clampWidth = (value: number) => | ||
| Math.max(minWidth, Math.min(value, computedMaxWidth)) | ||
|
|
||
| const updateMaxWidth = () => { |
There was a problem hiding this comment.
given theres a bit of maths here ideally wed ahve a test for the util at least
2 participants
Description
Increase the automation side panel default width from 400px to 480px and add horizontal resizing.
Implemented a reusable
ResizablePanelwrapper so this behavior can be reused across right/left side panels.Addresses
Screenshots
side.panel.mov
Launchcontrol
Automation side panels in the builder are now wider by default and can be resized by dragging the divider.