tighten access controls for global licence routes#18493
Open
tighten access controls for global licence routes#18493
Conversation
adrinr
reviewed
Apr 8, 2026
| ) | ||
|
|
||
| loggedInRoutes | ||
| adminRoutes |
Member
There was a problem hiding this comment.
This probably needs to support builders
Contributor
Author
There was a problem hiding this comment.
good call, I have opened up GET /api/global/license/usage and /api/global/license/key to all logged in users. I don't think non-admins need access to other license endpoints
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/worker/src/api/routes/global/license.ts">
<violation number="1" location="packages/worker/src/api/routes/global/license.ts:18">
P1: These GET endpoints were moved from adminRoutes to loggedInRoutes, which is defined without auth.adminOnly. That drops the admin-only restriction and lets non-admin users read license usage/key data.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
adrinr
reviewed
Apr 9, 2026
| }).required() | ||
| ) | ||
|
|
||
| loggedInRoutes |
Member
There was a problem hiding this comment.
Should that not be builderOrAdminRoutes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses
https://github.com/Budibase/vulns/issues/40
https://github.com/Budibase/budibase/security/advisories/GHSA-4wr8-5c3p-rjcr
Launchcontrol
tighten access controls for global licence routes