Increase the fallback for microSALT version command#4974
Open
RasmusBurge-CG wants to merge 6 commits intomasterfrom
Open
Increase the fallback for microSALT version command#4974RasmusBurge-CG wants to merge 6 commits intomasterfrom
RasmusBurge-CG wants to merge 6 commits intomasterfrom
Conversation
Contributor
Author
|
CodeFactor is warning about shell=True. As this is used in other tests and was accepted before, this warning can be disregarded. |
diitaz93
approved these changes
Mar 24, 2026
Contributor
diitaz93
left a comment
diitaz93
left a comment
There was a problem hiding this comment.
If this is the intended behaviour, it looks good 👍
Contributor
Author
|
Hi @diitaz93, I sent this back for review after some medium-sized refactoring. Curious to hear what you think about the update. :) |
|
diitaz93
reviewed
Mar 26, 2026
Comment on lines
+49
to
+58
|
|
||
| except Exception as e: | ||
|
|
||
| stderr = "" | ||
| if isinstance(e, subprocess.CalledProcessError): | ||
| stderr = e.stderr.decode("utf-8").rstrip() | ||
|
|
||
| LOG.warning( | ||
| f"Could not retrieve {case_config.workflow} workflow version: {e} : {stderr}" | ||
| ) |
Contributor
There was a problem hiding this comment.
Could we remove the spaces? not a fan of sparse code
Suggested change
| except Exception as e: | |
| stderr = "" | |
| if isinstance(e, subprocess.CalledProcessError): | |
| stderr = e.stderr.decode("utf-8").rstrip() | |
| LOG.warning( | |
| f"Could not retrieve {case_config.workflow} workflow version: {e} : {stderr}" | |
| ) | |
| except Exception as e: | |
| stderr = "" | |
| if isinstance(e, subprocess.CalledProcessError): | |
| stderr = e.stderr.decode("utf-8").rstrip() | |
| LOG.warning( | |
| f"Could not retrieve {case_config.workflow} workflow version: {e} : {stderr}" | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The general
Exceptioncould not handle the scenario when the exit code of get_workflow_version was unsuccessful.Changed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan