feat(tracing): add svc src tag when applicable from integration code#16612
feat(tracing): add svc src tag when applicable from integration code#16612emmettbutler wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e91ba0d26
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| config._add( | ||
| "tornado", | ||
| dict( | ||
| _default_service=schematize_service_name("tornado"), |
There was a problem hiding this comment.
Align Tornado default service with traced span service
Set _default_service to the same value Tornado spans actually use by default, otherwise the new _dd.svc.src tagging path never triggers for Tornado. application.tracer_config initializes request/template tracing with default_service = schematize_service_name(config._get_service("tornado-web")), but this change hard-codes _default_service as schematize_service_name("tornado"); as a result, default Tornado spans (tornado.request and tornado.template) won't satisfy the equality check used by maybe_set_service_source_tag, so the feature added in this commit is effectively disabled for Tornado.
Useful? React with 👍 / 👎.
Codeowners resolved as |
|
✨ Fix all issues with BitsAI or with Cursor
|
Performance SLOsComparing candidate emmett.butler/svc-src-tag (5ea56a0) with baseline main (5e36f7e) 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.494ms (SLO: <32.950ms -4.4%) vs baseline: +0.5% Memory: ✅ 36.667MB (SLO: <39.250MB -6.6%) vs baseline: +4.6% ✅ mediumTime: ✅ 3.091ms (SLO: <3.200ms -3.4%) vs baseline: -0.7% Memory: ✅ 35.488MB (SLO: <38.750MB -8.4%) vs baseline: +4.7% ✅ smallTime: ✅ 364.328µs (SLO: <370.000µs 🟡 -1.5%) vs baseline: +3.8% Memory: ✅ 35.488MB (SLO: <38.750MB -8.4%) vs baseline: +4.6%
|
Description
Testing
Risks
Additional Notes