Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new SignedExclusiveSwap extension for the Ekubo protocol. The extension enables forward-only swaps with controller-signed, per-swap fee customization. It implements MEVCapture-style fee timing where fees are collected into extension storage and donated to LPs at the start of the next block, preventing same-block liquidity changes from capturing historical fees.
Changes:
- Adds SignedExclusiveSwap extension with EIP-712 signature verification for swap authorization
- Implements packed type definitions for gas-efficient storage of swap metadata and pool state
- Provides library helpers for off-chain signature computation and on-chain swap execution
- Includes comprehensive test coverage for the extension, though missing some edge case tests
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/SignedExclusiveSwap.sol | Core extension implementation with signature verification, nonce management, and fee handling |
| src/types/signedSwapMeta.sol | Packed 256-bit type for swap authorization metadata (locker, deadline, fee, nonce) |
| src/types/signedExclusiveSwapPoolState.sol | Packed storage for per-pool controller and timestamp state |
| src/libraries/SignedExclusiveSwapLib.sol | Helper library for EIP-712 digest computation and swap execution |
| src/interfaces/extensions/ISignedExclusiveSwap.sol | Public interface definitions for the extension |
| test/extensions/SignedExclusiveSwap.t.sol | Comprehensive test suite covering main functionality paths |
| test/types/signedSwapMeta.t.sol | Unit tests for metadata packing/unpacking and expiry logic |
| test/types/signedExclusiveSwapPoolState.t.sol | Unit tests for pool state manipulation |
| snapshots/SignedExclusiveSwapTest.json | Gas consumption benchmarks |
| signed-exclusive-swap-extension.md | Technical documentation describing extension behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot please add the missing tests and run them to make sure they pass |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@moodysalem I've opened a new pull request, #323, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: moodysalem <7897876+moodysalem@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…es the reference calc
No description provided.