Add missing signature-failure coverage for SignedExclusiveSwap#320
Merged
moodysalem merged 2 commits intosigned-exclusive-swapfrom Feb 23, 2026
Merged
Add missing signature-failure coverage for SignedExclusiveSwap#320moodysalem merged 2 commits intosigned-exclusive-swapfrom
moodysalem merged 2 commits intosigned-exclusive-swapfrom
Conversation
Co-authored-by: moodysalem <7897876+moodysalem@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add SignedExclusiveSwap extension for Ekubo protocol
Add missing signature-failure coverage for SignedExclusiveSwap
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR feedback identified missing security-path coverage in
SignedExclusiveSwaptests: the suite did not assert explicit reverts for expired signatures or payload/signature mismatches. This update adds focused tests for both failure modes.Signature validation coverage
test_revert_signature_expiredto assertISignedExclusiveSwap.SignatureExpiredwhenmeta.deadlineis in the past.test_revert_invalid_signatureto assertISignedExclusiveSwap.InvalidSignaturewhen the signed payload differs from the payload used at execution.Targeted scope
test/extensions/SignedExclusiveSwap.t.sol.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.