[FIX] - Add memory quotas to Docker runs#36
Open
Surya-Gunukula wants to merge 1 commit intoNVlabs:mainfrom
Open
[FIX] - Add memory quotas to Docker runs#36Surya-Gunukula wants to merge 1 commit intoNVlabs:mainfrom
Surya-Gunukula wants to merge 1 commit intoNVlabs:mainfrom
Conversation
Implement configurable memory limits for Docker containers to prevent runaway memory usage from incorrectly generated Verilog code. Changes: - Add DOCKER_HARNESS_MEMORY_LIMIT and DOCKER_AGENT_MEMORY_LIMIT config options - Apply memory limits via --memory and --memory-swap flags in shell scripts - Memory limits applied to harness/evaluation containers (where iverilog runs) - Memory limits applied to agent containers (both code paths) - Backwards compatible: defaults to None (no limits if not configured) - Updated documentation in README_DEVELOPER.md and README_FULL.md This addresses issue NVlabs#18 where incorrectly generated Verilog can cause iverilog to consume excessive memory, leading to host system instability. Signed-off-by: Surya Gunukula <suryagunukula@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement configurable memory limits for Docker containers to prevent runaway memory usage from incorrectly generated Verilog code.
Changes:
Closes #18