afpd: use utimensat when storing kMDItemLastUsedDate for Spotlight#2897
Merged
afpd: use utimensat when storing kMDItemLastUsedDate for Spotlight#2897
Conversation
🤖 Augment PR SummarySummary: Updates Spotlight attribute storage so writing 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
rdmark
force-pushed
the
rdmark-utime-fix
branch
from
cf621be to
f2484d1
Compare
rdmark
force-pushed
the
rdmark-utime-fix
branch
from
f2484d1 to
823f3e6
Compare
Member
Author
|
augment review |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The previous utime() call left utimbuf.modtime uninitialised on the stack. utime() writes both atime and mtime, so the file's mtime was clobbered with garbage. Apps such as TextEdit compare the mtime they recorded at open time against the current mtime before saving; seeing an unexpected change they abort the save with "file modified by another application". Replace the utime() call with utimensat(AT_FDCWD, path, ts, 0) where ts[1].tv_nsec = UTIME_OMIT, which updates only the access time and leaves the modification time strictly unchanged.
rdmark
force-pushed
the
rdmark-utime-fix
branch
from
823f3e6 to
4d94b49
Compare
rdmark
changed the title
|
Member
Author
|
augment review |
Contributor
🔥 Spectest (AFP 3.4) - Flamegraph (AFP_ASSERT active)Commit: 🔥 Open interactive Flamegraph (SVG) 🔝 Top 10 leaf functions
|
andylemin
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous utime() call left utimbuf.modtime uninitialised on the stack. utime() writes both atime and mtime, so the file's mtime was clobbered with garbage. Apps such as TextEdit compare the mtime they recorded at open time against the current mtime before saving; seeing an unexpected change they abort the save with "file modified by another application".
Replace the utime() call with utimensat(AT_FDCWD, path, ts, 0) where ts[1].tv_nsec = UTIME_OMIT, which updates only the access time and leaves the modification time strictly unchanged.
Fixes breakage introduced in #2878