Skip to content

afpd: use utimensat when storing kMDItemLastUsedDate for Spotlight #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andylemin merged 1 commit into from
Apr 19, 2026
+13 −9
Merged

afpd: use utimensat when storing kMDItemLastUsedDate for Spotlight #2897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions etc/afpd/spotlight.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ static bool add_filemeta(sl_array_t *reqinfo,
name = dalloc_strdup(meta, path);
dalloc_add(meta, name, "char *");
} else if (strequal(reqinfo->dd_talloc_array[i], "kMDItemFSSize")
|| strequal(reqinfo->dd_talloc_array[i], "kMDItemLogicalSize")) {
|| strequal(reqinfo->dd_talloc_array[i], "kMDItemLogicalSize")) {
uint64var = sp->st_size;
dalloc_add_copy(meta, &uint64var, uint64_t);
} else if (strequal(reqinfo->dd_talloc_array[i],
Expand Down Expand Up @@ -1102,15 +1102,19 @@ static int sl_rpc_storeAttributesForOIDArray(const AFPObj *obj,
struct utimbuf utimes;
utimes.actime = utimes.modtime = sl_time->tv_sec;
utime(path, &utimes);
} else if ((sl_time = dalloc_value_for_key(query, "DALLOC_CTX", 0, "DALLOC_CTX",
1, "DALLOC_CTX", 1, "kMDItemLastUsedDate", "sl_time_t"))) {
/*
* Update atime only. Using utimensat with UTIME_OMIT on the mtime
* slot avoids touching mtime.
*/
struct timespec ts[2] = {{0}};
ts[0].tv_sec = sl_time->tv_sec;
ts[0].tv_nsec = sl_time->tv_usec * 1000;
Comment thread
rdmark marked this conversation as resolved.
ts[1].tv_nsec = UTIME_OMIT;
Comment thread
rdmark marked this conversation as resolved.
utimensat(AT_FDCWD, path, ts, 0);
Comment thread
rdmark marked this conversation as resolved.
}
else if ((sl_time = dalloc_value_for_key(query, "DALLOC_CTX", 0, "DALLOC_CTX", 1,
"DALLOC_CTX", 1,
"kMDItemLastUsedDate", "sl_time_t"))) {
struct utimbuf atimes;
atimes.actime = sl_time->tv_sec;
utime(path, &atimes);
}


array = talloc_zero(reply, sl_array_t);
uint64_t sl_res = 0;
dalloc_add_copy(array, &sl_res, uint64_t);
Expand Down
Loading