Skip to content

maven: 3.8.6 -> 3.9.2#238746

Merged
wegank merged 2 commits intoNixOS:masterfrom
Tillerino:update/maven
Jun 20, 2023
Merged

maven: 3.8.6 -> 3.9.2#238746
wegank merged 2 commits intoNixOS:masterfrom
Tillerino:update/maven

Conversation

@Tillerino
Copy link
Copy Markdown
Contributor

@Tillerino Tillerino commented Jun 20, 2023

Description of changes

Closes #230162, closes #229144.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Since the newer Maven pulls different versions of its own dependencies,
the hashes of these derivations all changed.
@Tillerino
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 238746 run on x86_64-linux 1

14 packages built:
  • cryptomator
  • dbeaver
  • digital
  • exhibitor
  • forge-mtg
  • gephi
  • global-platform-pro
  • java-language-server
  • jd-cli
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • kotlin-language-server
  • maven
  • schemaspy

@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 20, 2023

@ofborg build maven maven.passthru.tests

@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 20, 2023

Result of nixpkgs-review pr 238746 run on aarch64-darwin 1

9 packages built:
  • dbeaver
  • exhibitor
  • forge-mtg
  • global-platform-pro
  • java-language-server
  • jd-cli
  • kotlin-language-server
  • maven
  • schemaspy

@wegank wegank marked this pull request as ready for review June 20, 2023 11:45
@wegank wegank merged commit 5084747 into NixOS:master Jun 20, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented Jun 20, 2023

Thank you!

@Tillerino Tillerino deleted the update/maven branch June 20, 2023 12:40
Tillerino added a commit to Tillerino/nixpkgs that referenced this pull request Jun 20, 2023
};

mvnHash = "sha256-87pf7XRXCuZlAbL54pX+a5Lo/874DmUr/W37/V+5YpQ=";
mvnHash = "sha256-ERZYDsPxp1YXteSmunFIgTGZUYqjZJhqrNytLnIUNBQ=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note to self) This package is up-to-date and I opened a PR to enforce all maven plugin versions to be set. With the next update of this package, the hash should no longer be affected by the Maven version.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would you like to propose a PR to supersede #232348?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, I got the wrong file. I wanted to make this note on the forge-mtg file. I'm going though r/n and will be making notes as I go.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I got to this repo now and opened the enforce PR: dbeaver/dbeaver#20341

I don't think it's worth waiting for a merge and release, so please disregard w.r.t. #232348

# Tests need a running Xorg.
mvnParameters = "-DskipTests";
mvnHash = "sha256-Bq02zyOZjah5jtFBEvE+Xif6aAAwPiuP5sUL42V8dUs=";
mvnHash = "sha256-ajrHnaiJS7ZnR9BjLaXK2bnAKCp5UWQqYpjWbz3z6bw=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note to self) This package is up-to-date and I opened a PR to enforce all maven plugin versions to be set. With the next update of this package, the hash should no longer be affected by the Maven version.


inherit mvnParameters;
mvnHash = "sha256-tc4mrXeyeI973IsNA9CcYJXEtTj91DcpCSmVYBYytt8=";
mvnHash = "sha256-Ej/JePvd9Ieni8FqSaXBDc2T6Cwr8WP54iko8wYiT68=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also up-to-date and I opened a PR: hneemann/Digital#1170

outputHashAlgo = "sha256";
outputHashMode = "recursive";
outputHash = "1qwgvz6l5wia8q5824c9f3iwyapfskljhqf1z09fw6jjj1jy3b15";
outputHash = "sha256-rRLsCTY3fEAvGRDvNXqpjac2Gb5fdlyhK2wTK5CVN9k=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not up-to-date at all. Opened a PR about the plugin versions anyway: martinpaljak/GlobalPlatformPro#321

mvnFetchExtraArgs.dontConfigure = true;
mvnParameters = "-DskipTests";
mvnHash = "sha256-2MVlF3QIWiDvUlnMH4RLi2Od57aoh8zK/OmHqztOnZ4=";
mvnHash = "sha256-bzYBSrCS9Kp+qnVO60h915Or1VWabphwLEu6lcBULuc=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note to self) this project seems kind of dead. there are really trivial PRs that haven't been merged in months :(

I threw in the enforce PR just to kind of see what will happen: georgewfraser/java-language-server#259

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, this was merged :)

Comment thread pkgs/servers/exhibitor/default.nix
};

mvnHash = "sha256-EIam0rxmCBs/mpMck6ePFoQBQ6KYYNqJKVE32gdXPfE=";
mvnHash = "sha256-kLpjMj05uC94/5vGMwMlFzLKNFOKeyNvq/vmB6pHTAo=";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note to self) This package was up to date. Opened an enforce PR: intoolswetrust/jd-cli#94

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged

@soupglasses soupglasses mentioned this pull request Jul 29, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants