Skip to content

[19.0][MIG] edi_product_oca: Migration to 19.0#287

Merged
OCA-git-bot merged 9 commits into
OCA:19.0from
camptocamp:19.0-mig-edi_product_oca
Jun 4, 2026
Merged

[19.0][MIG] edi_product_oca: Migration to 19.0#287
OCA-git-bot merged 9 commits into
OCA:19.0from
camptocamp:19.0-mig-edi_product_oca

Conversation

@yankinmax

@yankinmax yankinmax commented May 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Ricardoalso
Ricardoalso approved these changes May 22, 2026
View reviewed changes

@Ricardoalso Ricardoalso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM

In the GUI, I noticed that the edi_disable_auto field is displayed oddly. It was already slightly off-screen in v18, but now the rendering looks very strange:

18.0

Image

19.0

Image

Could you align if to the left ? 🙏

@yankinmax yankinmax force-pushed the 19.0-mig-edi_product_oca branch 3 times, most recently from 3c0f3fe to c2f1d18 Compare May 25, 2026 07:50
@yankinmax

yankinmax commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@Ricardoalso fixed

simahawk
simahawk requested changes May 25, 2026
View reviewed changes
Comment thread edi_product_oca/__manifest__.py Outdated
"website": "https://github.com/OCA/edi-framework",
"depends": [
"product",
"edi_endpoint_oca",

@simahawk simahawk May 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency is wrong as is coming from v18. It must be fixed there too.
It should be only edi_core_oca.

@yankinmax yankinmax May 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened similar PR on v18:

@yankinmax yankinmax force-pushed the 19.0-mig-edi_product_oca branch from c2f1d18 to dc4eb01 Compare May 25, 2026 08:34
@yankinmax yankinmax mentioned this pull request May 25, 2026
Open
1 task
vvrossem
vvrossem approved these changes May 25, 2026
View reviewed changes

@vvrossem vvrossem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration commit LG

Comment thread edi_product_oca/views/uom_uom_views.xml Outdated
vvrossem
vvrossem reviewed May 25, 2026
View reviewed changes
Comment thread edi_product_oca/models/uom_uom.py Outdated
@yankinmax yankinmax force-pushed the 19.0-mig-edi_product_oca branch from dc4eb01 to 18e3d5b Compare May 25, 2026 12:34
@ivantodorovich

ivantodorovich commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@simahawk is good for you now?

simahawk
simahawk reviewed Jun 3, 2026
View reviewed changes
Comment thread edi_product_oca/__manifest__.py Outdated
"depends": [
# Odoo/core
"product",
"edi_endpoint_oca",

@simahawk simahawk Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the removal of the dependency on endpoint has be "hidden" in the migration commit...

Question: so apparently it works on 19 but not on 18?
See #290 (comment)

@yankinmax yankinmax Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: so apparently it works on 19 but not on 18?

Answer => yep!

I'll update these two PR's and ping you very soon, thank you!

@yankinmax yankinmax Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk done!

@OCA-git-bot

OCA-git-bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yankinmax yankinmax force-pushed the 19.0-mig-edi_product_oca branch from 18e3d5b to 7cb6e2e Compare June 3, 2026 07:41
@simahawk

simahawk commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/ocabot migration edi_product_oca
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jun 4, 2026
@OCA-git-bot

OCA-git-bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-287-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 4, 2026
Open
26 tasks
@OCA-git-bot OCA-git-bot merged commit acf1754 into OCA:19.0 Jun 4, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c7f207e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes
+3 more reviewers
@vvrossem vvrossem vvrossem approved these changes
@grindtildeath grindtildeath grindtildeath approved these changes
@Ricardoalso Ricardoalso Ricardoalso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:edi_product_oca Module edi_product_oca ready to merge series:19.0

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.