[18.0][FIX] edi_product_oca: fix wrong dep on edi_endpoint_oca#290
Open
yankinmax wants to merge 1 commit into
Open
[18.0][FIX] edi_product_oca: fix wrong dep on edi_endpoint_oca#290yankinmax wants to merge 1 commit into
yankinmax wants to merge 1 commit into
Conversation
yankinmax
changed the title
Contributor
|
the reason is not "edi core revamp". The dependency on endpoint module is wrong by itself and I don't know why it has been added 😉 |
simahawk
changed the title
Contributor
Author
|
@simahawk good to know, thanks |
Contributor
|
I'm checking the test issue |
cyrilmanuel
approved these changes
May 27, 2026
Contributor
|
@yankinmax I've not managed to fix this yet. Do me a favor: live it like it is today w/ the dependency but add a TODO and report there the motivation. A simple glue module for edi_product + endpoint does not work as it does for edi_sale_endpoint so... let's not waste too much time on something that is like that since ages. |
yankinmax
force-pushed
the
imp-edi_product_oca-chg-dep
branch
from
79f4350 to
c436cba
Compare
Contributor
Author
|
@simahawk done! |
Contributor
|
@yankinmax pls rewrite the commit msg |
The direct dependency on edi_endpoint_oca is not conceptually correct: edi_product_oca should only need edi_core_oca. However, removing edi_endpoint_oca on 18.0 currently breaks CI because origin_edi_endpoint_id can be set up on product models while its related target edi.exchange.record.edi_endpoint_id is missing. Keep the dependency for now and add a TODO comment to remove it in version 19.0
yankinmax
force-pushed
the
imp-edi_product_oca-chg-dep
branch
from
c436cba to
40e2366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See requested changes:
cc @simahawk