ProductSupplierInfoImport: create product.product instead of product.template ?

[DylannCordel]

Hi,

In product_supplierinfo_import.py ProductSupplierInfoImport._create_new_product, you try to create a product.template and if it fails you return an empty product.product. Maybe I misunderstood something but it would be better to return an empty product.template ? Or even better, try to create a product.product instead a product.template ?

product-attribute/product_supplierinfo_import/wizards/product_supplierinfo_import.py

Lines 225 to 236 in dae07e0

	try:
	product = self.env["product.template"].create(product_data)
	product.message_post(
	body=self.env._("Created from supplier price list import"),
	)
	return product
	except ValidationError:
	_logger.warning(
	f"The product {vendor_product_name}"
	f" could not be created due to a {search_field} collision."
	)
	return self.env["product.product"]

Sorry if I miss something to understand why it's currently done as it.