Pneumatic Valve Suite Dependency Updates#8491
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot created this pull request from a session on behalf of
rmroot
May 26, 2026 20:37
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the AMO-Tools-Desktop side of the MEASUR-Tools-Suite pneumatic valve refactor (Suite PR #341), replacing the old class-based WASM binding with two standalone functions and wiring up a new calculator UI.
Checklist
#8490Description
API Binding Changes
Old class-based pattern removed, replaced with two direct WASM function calls:
standalone.ts: Replaced commented-outPneumaticValveinterface withPneumaticValveFlowRateInput/OutputandPneumaticValveCvInput/Outputstandalone-suite-api.service.ts: ImplementedpneumaticValveCalculateFlowRate()andpneumaticValveCv()against the new WASM functionsstandalone.service.ts: Added Imperial/Metric unit conversion wrappers (psia↔kPaa, scfm↔Nm³/min)New Calculator UI (
/calculators/pneumatic-valve)Two-mode calculator following the existing compressed air calculator pattern:
Help panel includes per-field descriptions and a link to the suite documentation at
group__pneumatic__valve__calculator.Registration
compressed-air.module.ts— importsPneumaticValveModulecore.routing.ts— addspneumatic-valverouteanalyticsEventTypes.ts— addscalculator-CA-pneumatic-valvedocs/calculator_list.md— entry added with Docs link