Do not always cache BRepClass3d_SolidClassifier#1046
Open
ton wants to merge 2 commits intoOpen-Cascade-SAS:OCCT-793from
Open
Do not always cache BRepClass3d_SolidClassifier#1046ton wants to merge 2 commits intoOpen-Cascade-SAS:OCCT-793from
BRepClass3d_SolidClassifier#1046ton wants to merge 2 commits intoOpen-Cascade-SAS:OCCT-793from
Conversation
Do not cache `BRepClass3d_SolidClassifier` up front when checking whether a shell is a hole shell. This prevents redundant storage of `BRepClass3d_SolidClassifier` instances for non-hole shells.
dpasukhi
added
the
3. CLA waited
Author
|
CLA ID: 1134 |
dpasukhi
added
3. CLA approved
Member
|
Dear Ton thank you for your patch. At the moment, 793 is frozen and not planned to be updated until critical security or stability patch. Best regards, Dmitrii. |
Member
|
Again, my apologies, after review of your changes, for now the changes I will keep on hold. Thank you for your investigation. In case if I will not find better solution I will migrate your patch into latest version. best regards, Dmitrii. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR reduces memory usage for a BOPAlgo cut operation, by only caching
BRepClass3d_SolidClassifierinBOPAlgo_BuilderSolidin case of a hole shell. This reduces the peak RSS memory usage for the same example use case as attached to #1045 from 110MiB to 87MiB on my machine.The drawback is that in case we are dealing with a hole shell,
BRepClass3d_SolidClassifieris calculated twice, but for the cases I observed, this has no noticeable impact on performance.