Skip to content

Do not always cache BRepClass3d_SolidClassifier #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ton wants to merge 2 commits into
base: OCCT-793
Choose a base branch
from
Open

Do not always cache BRepClass3d_SolidClassifier #1046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49db3e2
Do not always cache `BRepClass3d_SolidClassifier`
ton Feb 2, 2026
2d89e34
Apply clang-format
ton Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/BOPAlgo/BOPAlgo_BuilderSolid.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

//
static Standard_Boolean IsGrowthShell(const TopoDS_Shape&, const TopTools_IndexedMapOfShape&);
static Standard_Boolean IsHole(const TopoDS_Shape&, Handle(IntTools_Context)&);
static Standard_Boolean IsHole(const TopoDS_Shape&);
static Standard_Boolean IsInside(const TopoDS_Shape&,
const TopoDS_Shape&,
Handle(IntTools_Context)&);
Expand Down Expand Up @@ -421,7 +421,7 @@ void BOPAlgo_BuilderSolid::PerformAreas(const Message_ProgressRange& theRange)
if (!bIsGrowth)
{
// Fast check did not give the result, run classification
bIsGrowth = !IsHole(aShell, myContext);
bIsGrowth = !IsHole(aShell);
}

// Save the solid
Expand Down Expand Up @@ -791,13 +791,13 @@ void MakeInternalShells(const TopTools_IndexedMapOfShape& theMF, TopTools_ListOf

//=================================================================================================

Standard_Boolean IsHole(const TopoDS_Shape& theS2, Handle(IntTools_Context)& theContext)
Standard_Boolean IsHole(const TopoDS_Shape& theS2)
{
TopoDS_Solid* pS2 = (TopoDS_Solid*)&theS2;
BRepClass3d_SolidClassifier& aClsf = theContext->SolidClassifier(*pS2);
//
TopoDS_Solid* pS2 = (TopoDS_Solid*)&theS2;

BRepClass3d_SolidClassifier aClsf(*pS2);
aClsf.PerformInfinitePoint(::RealSmall());
//

return (aClsf.State() == TopAbs_IN);
}

Expand Down
Loading