fix(rocprim): check if wave size is supported in warp_sort benchmark#4886
Open
MyNameIsTrez wants to merge 1 commit intodevelopfrom
Open
fix(rocprim): check if wave size is supported in warp_sort benchmark#4886MyNameIsTrez wants to merge 1 commit intodevelopfrom
MyNameIsTrez wants to merge 1 commit intodevelopfrom
Conversation
MyNameIsTrez
force-pushed
the
users/mynameistrez/check-warp-size-in-warp-sort-benchmark
branch
from
cfc1ee7 to
633a1ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4886 +/- ##
===========================================
- Coverage 65.36% 63.05% -2.31%
===========================================
Files 1718 1870 +152
Lines 267205 292897 +25692
Branches 37045 37612 +567
===========================================
+ Hits 174633 184664 +10031
- Misses 77066 92350 +15284
- Partials 15506 15883 +377
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
stanleytsang-amd
approved these changes
Feb 26, 2026
Contributor
stanleytsang-amd
left a comment
stanleytsang-amd
left a comment
There was a problem hiding this comment.
Apologies for the oversight on my part. Approved, pending CI checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocPRIM its
benchmark_warp_sort.cpphad compilation and runtime errors, which have now been fixed.Technical Details
Sinus Rollins from Stream HPC had originally fixed the runtime error in a GitLab merge request, but since he has been sick for the past couple of days, I have created this pull request for him and updated his commit.
PR Temporarily disable benchmark_warp_sort cases was merged yesterday, and it accidentally introduced the compilation error when attempting to fix the very same runtime error. Its fix was Windows-specific, so failed to compile on Linux.
Test Plan
I first reproduced the Linux compilation and runtime error on our Navi GPU (RX 9070 XT, so gfx1201):
ninja benchmark_warp_sort && benchmark/benchmark_warp_sortTest Result
I confirmed that the compilation and runtime error is fixed by this PR on the same Navi GPU. All 40/40 benchmark specializations run without any runtime errors.
On our non-Navi GPU (MI210, so gfx90a), all 184/184 benchmark specializations run without any runtime errors.
Submission Checklist