Skip to content

fix(render): hold the shadow camera across a skipped map - #246

Draft
avpbynf wants to merge 1 commit into
devfrom
fix/hold-shadow-camera
Draft

fix(render): hold the shadow camera across a skipped map#246
avpbynf wants to merge 1 commit into
devfrom
fix/hold-shadow-camera

Conversation

@avpbynf

@avpbynf avpbynf commented Aug 30, 2026

Copy link
Copy Markdown
Owner

What changes

WAIT. Not tried on a Mac from this machine. Do not merge until a Mac reporter signs it.

When the shadow stage opens and then gives up without drawing, the published matrices used to treat the miss as a fresh map and walk the light with the player. They now keep the camera of the frame that last drew the map. Written for the Mac reports on #161 where lighting followed the player. This does not close #161.

How it differs from the reference, and for what obstacle

Iris draws the shadow map in the same frame it is sampled. This engine draws the map at the end of the frame for the next one, so the published pair is usually the previous frame's. A skipped map made that pair advance with the player while the texels stayed put, which reads as lighting that follows you. Holding the last drawn camera is the workaround for that skip. What it costs the image on a frame that did draw is nothing; the hold only runs on a skip.

What proves it

  • gradlew build green.
  • The out-of-game harness, and which corpus it ran over.
  • In the game: not tried on a Mac from this machine. No Windows-verified claim.

What it leaves owing

WAIT on a Mac sign-off. #161 stays open. This is the hold across a skipped map, not a proof that Apple Silicon is fast.


  • Rebased onto dev, so the merge is a fast-forward.
  • gradlew build green locally, after the rebase and not before it.
  • CHANGELOG.md carries an entry under Unreleased, or this changes nothing a player sees.
  • Every place that states a fact this branch changed now states the new one. A fact is cited
    in more places than it lives in: javadoc, docs/, README.md, and the lines the engine
    prints at load.

When the shadow stage opens and gives up, the published matrices used
to treat the miss as a fresh map and walk the light with the player.
Keep the camera of the frame that last drew. Not tried on a Mac from
this machine. For the #161 reporters.
@github-actions github-actions Bot added the fix a defect corrected, in the image or in what a pack may say label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix a defect corrected, in the image or in what a pack may say

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant