Resolve "Non ANSI-C style input,output port declaration Verilog code linter issue"#2447
Draft
matlupi wants to merge 5 commits intochipsalliance:masterfrom
Draft
Resolve "Non ANSI-C style input,output port declaration Verilog code linter issue"#2447matlupi wants to merge 5 commits intochipsalliance:masterfrom
matlupi wants to merge 5 commits intochipsalliance:masterfrom
Conversation
matlupi
commented
Aug 22, 2025
matlupi
commented
- Implements matching of non ANSI-C port style and direction to lint it with port_name_suffix_check based on Non ANSI-C style input,output port declaration Verilog code linter issue #2429 (comment)
- Implements testcases (positive, negative for the above)
Collaborator
|
Currently, this does not compile; are you still working on it ? |
hzeller
reviewed
Aug 27, 2025
| const auto token = identifier_leaf->get(); | ||
| const auto direction = | ||
| direction_leaf ? direction_leaf->get().text() : implicit_direction; | ||
| std::string direction; |
Collaborator
There was a problem hiding this comment.
Why not std::string_view ? The texts you assign are guaranteed to exist for the lifetime, and you also save std::string conversion.
Author
Yes, but help is definitely needed |
Collaborator
|
For the compile error, looks like you need to fully qualify the name in line 117: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.