Skip to content

Remove the tag.sh script#131

Open
jsf9k wants to merge 1 commit intodevelopfrom
improvement/remove-tag-script
Open

Remove the tag.sh script#131
jsf9k wants to merge 1 commit intodevelopfrom
improvement/remove-tag-script

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 27, 2022

🗣 Description

This pull request removes the tag.sh script.

💭 Motivation and context

Tags should instead be created indirectly via prereleases and releases, so there is some documentation associated with the version.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Tags should instead be created indirectly via releases, so there is
some documentation associated with the release.
@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Oct 27, 2022
@jsf9k jsf9k marked this pull request as ready for review October 27, 2022 14:53
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@mcdonnnj
Copy link
Member

I mentioned in cisagov/.github#47 (comment) some reservations I have about removing manual tagging from our projects. I would like team consensus before moving forward with any PRs around those changes (including this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked This issue or pull request is awaiting the outcome of another issue or pull request

Projects

Status: No status
Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants