Skip to content

feat(tekton): add Tekton Pipelines eval tasks#917

Open
ksimon1 wants to merge 1 commit intocontainers:mainfrom
ksimon1:tekton-evals
Open

feat(tekton): add Tekton Pipelines eval tasks#917
ksimon1 wants to merge 1 commit intocontainers:mainfrom
ksimon1:tekton-evals

Conversation

@ksimon1
Copy link
Contributor

@ksimon1 ksimon1 commented Mar 12, 2026

feat(tekton): add Tekton Pipelines install/uninstall/status Makefile targets and eval tasks

This PR introduces a new tekton eval set to kubernetes-mcp-server, exposing domain-specific Tekton operations.

@ksimon1 ksimon1 changed the title feat(tekton): add Tekton Pipelines install/uninstall/status Makefile … feat(tekton): add Tekton Pipelines eval tasks Mar 12, 2026
Copy link

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. The eval tasks are well-structured and the Makefile targets follow the existing kubevirt pattern. Since this lands before #892 (the tekton toolset implementation), a couple things to clean up:

  1. Forward references to the tekton toolset: The Makefile and README reference the tekton toolset and its tools (tekton_pipeline_start, etc.) which won't exist until #892 merges. The eval tasks themselves work fine via the core toolset's resources_* tools, but the docs will be misleading in the window between this merging and #892 merging. Either remove the forward references or add a note like "requires #892 for dedicated tekton tools, works with core toolset in the meantime."

  2. Setup script duplication: The 20-line namespace cleanup/wait loop is identical across all 9 tasks (~180 lines of duplication). Would be worth extracting to helpers/cleanup-namespace.sh like kubevirt does with helpers/verify-vm.sh.

…targets and eval tasks

Add basic eval tests for tekton pipelines
Signed-off-by: Karel Simon <ksimon@redhat.com>
@ksimon1
Copy link
Contributor Author

ksimon1 commented Mar 16, 2026

@waveywaves thanks for the review. Your comments should be resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants