feat(tekton): add Tekton Pipelines eval tasks#917
feat(tekton): add Tekton Pipelines eval tasks#917ksimon1 wants to merge 1 commit intocontainers:mainfrom
Conversation
waveywaves
left a comment
There was a problem hiding this comment.
Nice addition. The eval tasks are well-structured and the Makefile targets follow the existing kubevirt pattern. Since this lands before #892 (the tekton toolset implementation), a couple things to clean up:
-
Forward references to the
tektontoolset: The Makefile and README reference thetektontoolset and its tools (tekton_pipeline_start, etc.) which won't exist until #892 merges. The eval tasks themselves work fine via the core toolset'sresources_*tools, but the docs will be misleading in the window between this merging and #892 merging. Either remove the forward references or add a note like "requires #892 for dedicated tekton tools, works with core toolset in the meantime." -
Setup script duplication: The 20-line namespace cleanup/wait loop is identical across all 9 tasks (~180 lines of duplication). Would be worth extracting to
helpers/cleanup-namespace.shlike kubevirt does withhelpers/verify-vm.sh.
…targets and eval tasks Add basic eval tests for tekton pipelines Signed-off-by: Karel Simon <ksimon@redhat.com>
|
@waveywaves thanks for the review. Your comments should be resolved now |
feat(tekton): add Tekton Pipelines install/uninstall/status Makefile targets and eval tasks
This PR introduces a new tekton eval set to kubernetes-mcp-server, exposing domain-specific Tekton operations.