Fix: TreeView icon swap + prevent getChildren on collapse#1256
Open
radimvaculik wants to merge 1 commit intomasterfrom
Open
Fix: TreeView icon swap + prevent getChildren on collapse#1256radimvaculik wants to merge 1 commit intomasterfrom
radimvaculik wants to merge 1 commit intomasterfrom
Conversation
…ildren on collapse - Add collapsed/expanded/loading icons to template, toggled via CSS state classes - Prevent AJAX request when collapsing (intercept interact event) - Show spinner icon while loading, chevron-down when expanded
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transform: rotatewith proper icon swapping (chevron-right→chevron-down)getChildrenAJAX request is in flighthandleGetChildrenfrom being called when closing the treeview (intercepts theinteractevent and cancels it)Closes #578
Changes
datagrid_tree.latte: three icons in the chevron<a>(collapsed,expanded,loading), each with adata-tree-iconattributedatagrid.css: CSS visibility rules driven by.is-loading/.is-expandedstate classes; removed dead.toggle-rotateandtransition: transformtreeView.ts: JS now only toggles state classes; no more icon prefix detectionTest plan
Screenshot