-
Notifications
You must be signed in to change notification settings - Fork 5k
[metricbeat][system] add swap field to system.process.memory metricset #48334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricbeat][system] add swap field to system.process.memory metricset #48334
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
orestisfl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run make update
🔍 Preview links for changed docs |
ishleenk17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit, otherwise looks good.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
|
After giving this some additional thought—and considering that version 9.4 is still quite a while away—should we consider backporting this change, perhaps to 9.3? cc @ishleenk17 |
@stefans-elastic : Since the request came from the customer who is on 8.19. |
|
/test |
|
@Mergifyio backport 8.19 9.1 9.2 9.3 |
✅ Backports have been createdDetails
Cherry-pick of 90844ec has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 90844ec has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 90844ec has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 90844ec has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
#48334) * [metricbeat][system] add swap field to system.process.memory metricset * update docs * update NOTICE.txt * remove field mapping * make changelog message more accurate * revert removing of field mapping * resolve PR comment * Update metricbeat/module/system/process/_meta/fields.yml Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * make update * update swap field ga version --------- Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> (cherry picked from commit 90844ec) # Conflicts: # NOTICE.txt # docs/reference/metricbeat/exported-fields-system.md # docs/reference/metricbeat/metricbeat-metricset-system-process.md # go.mod # go.sum # metricbeat/module/system/fields.go
#48334) * [metricbeat][system] add swap field to system.process.memory metricset * update docs * update NOTICE.txt * remove field mapping * make changelog message more accurate * revert removing of field mapping * resolve PR comment * Update metricbeat/module/system/process/_meta/fields.yml Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * make update * update swap field ga version --------- Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> (cherry picked from commit 90844ec) # Conflicts: # NOTICE.txt # go.mod # go.sum # metricbeat/module/system/fields.go
#48334) * [metricbeat][system] add swap field to system.process.memory metricset * update docs * update NOTICE.txt * remove field mapping * make changelog message more accurate * revert removing of field mapping * resolve PR comment * Update metricbeat/module/system/process/_meta/fields.yml Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * make update * update swap field ga version --------- Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> (cherry picked from commit 90844ec) # Conflicts: # NOTICE.txt # go.mod # go.sum # metricbeat/module/system/fields.go
#48334) * [metricbeat][system] add swap field to system.process.memory metricset * update docs * update NOTICE.txt * remove field mapping * make changelog message more accurate * revert removing of field mapping * resolve PR comment * Update metricbeat/module/system/process/_meta/fields.yml Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * make update * update swap field ga version --------- Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> (cherry picked from commit 90844ec) # Conflicts: # go.mod # go.sum
|
I've gotten a question: The error is due to the fact that this PR hasn't bee backported and the functionality is available only in 9.3+. I don't see a way to backport my PR without bringing the changes from I assume we have 2 options here:
Or maybe I'm not seeing a way to backport this PR without bringing changes from Please advise with the best course of action here. |
Proposed commit message
See title
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
On Linux

Some validation of the output

As is visible on the screenshot process with PID 43 and 90 really used no swap memory. And process with PID 640 used 1272 kB of swap memory (which is 1302528 bytes) and it matches what is shown in Kibana.
To make sure nothing breaks on other platforms I've run a test on macos (it is working fine, swap field is null on other than Linux platforms)

Logs