-
Notifications
You must be signed in to change notification settings - Fork 5k
[9.2](backport #48334) [metricbeat][system] add swap field to system.process.memory metricset #48485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mergify
wants to merge
3
commits into
9.2
Choose a base branch
from
mergify/bp/9.2/pr-48334
base: 9.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#48334) * [metricbeat][system] add swap field to system.process.memory metricset * update docs * update NOTICE.txt * remove field mapping * make changelog message more accurate * revert removing of field mapping * resolve PR comment * Update metricbeat/module/system/process/_meta/fields.yml Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> * make update * update swap field ga version --------- Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com> (cherry picked from commit 90844ec) # Conflicts: # NOTICE.txt # go.mod # go.sum # metricbeat/module/system/fields.go
Contributor
Author
|
Cherry-pick of 90844ec has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
🔍 Preview links for changed docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
conflicts
There is a conflict in the backported pull request
enhancement
Metricbeat
Metricbeat
Team:Obs-InfraObs
Label for the Observability Infrastructure Monitoring team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
On Linux

Some validation of the output

As is visible on the screenshot process with PID 43 and 90 really used no swap memory. And process with PID 640 used 1272 kB of swap memory (which is 1302528 bytes) and it matches what is shown in Kibana.
To make sure nothing breaks on other platforms I've run a test on macos (it is working fine, swap field is null on other than Linux platforms)

Logs
This is an automatic backport of pull request #48334 done by [Mergify](https://mergify.com).