fix: Gate GooglePolyline and format Nimble tests#868
Open
duxiao1212 wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108570476. |
meta-codesync
Bot
changed the title
duxiao1212
added a commit
to duxiao1212/nimble
that referenced
this pull request
Jun 15, 2026
Summary: Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, and apply clang-format fixes required by the Nimble GitHub pre-commit job. Differential Revision: D108570476
duxiao1212
force-pushed
the
export-D108570476
branch
from
acf2a46 to
93016f9
Compare
meta-codesync
Bot
changed the title
duxiao1212
force-pushed
the
export-D108570476
branch
from
93016f9 to
d618966
Compare
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Jun 15, 2026
Summary: X-link: facebookincubator/nimble#868 Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job. Differential Revision: D108570476
Summary: Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job. Differential Revision: D108570476
duxiao1212
force-pushed
the
export-D108570476
branch
from
d618966 to
0225bc3
Compare
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Jun 15, 2026
Summary: X-link: facebookincubator/nimble#868 Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job. Differential Revision: D108570476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move GooglePolylineFunctions.cpp behind VELOX_ENABLE_GEO in CMake so OSS builds without GEOS do not compile it, declare the direct geo dependencies explicitly, and apply clang-format fixes required by the Nimble GitHub pre-commit job.
Differential Revision: D108570476