move examples dependencies into their own "extras" section.#800
Closed
nega0 wants to merge 1 commit intographnet-team:mainfrom
Closed
move examples dependencies into their own "extras" section.#800nega0 wants to merge 1 commit intographnet-team:mainfrom
nega0 wants to merge 1 commit intographnet-team:mainfrom
Conversation
AwkwardArray doesn't build with CMake v4 and prevents building graphnet. This moves it and `timers` into an examples "extra" since that's the only place they're used.
Collaborator
|
Hi @nega0! Thank you for reporting this, and apologies for the slow response. The usage of these libraries has decreased quite a bit (we used to use them more), and as you point out here, including these as dependencies in graphnet is unnecessary. I've created a pull request #808 that removes these two libraries. Given that this PR has failing checks, I think we should close this PR in favor of #808 as they achieve the same. Is that OK with you? |
Author
|
Closing in favor of #808 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AwkwardArray doesn't build with CMake v4 and prevents building graphnet.
This moves it and
timersinto an examples "extra" since that's theonly place they're used.