Remove awkward and timer from dependencies#808
Merged
RasmusOrsoe merged 2 commits intographnet-team:mainfrom Jun 17, 2025
Merged
Remove awkward and timer from dependencies#808RasmusOrsoe merged 2 commits intographnet-team:mainfrom
awkward and timer from dependencies#808RasmusOrsoe merged 2 commits intographnet-team:mainfrom
Conversation
This was referenced Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @nega0 in #800 ,
awkwardandtimerproduce build errors in CMake.The two libraries are currently only used in the examples
data_02/01_read_dataset.pyanddata_02/04_ensemble_dataset.py. In the past, we relied on these libraries more, but at this stage, I think it's unnecessary to include them as dependencies in GraphNeT.This PR modifies the two examples to not rely on the dependencies, and removes the two libraries from the list of dependencies for GraphNeT.
The PR also close #774