Skip to content

chore(opentelemetry): use standard withState util#1810

Open
EmrysMyrddin wants to merge 2 commits intomainfrom
chore/otel/standard-with-state
Open

chore(opentelemetry): use standard withState util#1810
EmrysMyrddin wants to merge 2 commits intomainfrom
chore/otel/standard-with-state

Conversation

@EmrysMyrddin
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @EmrysMyrddin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the OpenTelemetry plugin by adopting the withState utility from the @envelop/core package. This change removes custom state management logic, enhancing consistency and reducing the maintenance burden by relying on a well-established library utility.

Highlights

  • Dependency Update: Added @envelop/core as a new dependency to the OpenTelemetry plugin, enabling the use of its standardized state management utilities.
  • Code Removal: Eliminated the custom plugin-utils.ts file, which previously contained a bespoke withState utility and associated types, reducing custom code overhead.
  • Standardized Utility Adoption: Migrated the OpenTelemetry plugin to leverage the standard withState utility and state management types provided by @envelop/core, improving consistency and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the opentelemetry plugin to use the standard withState utility from @envelop/core instead of a custom implementation. This is a great improvement as it reduces code duplication and maintenance overhead. The changes are straightforward, with the removal of the local plugin-utils.ts file and updating the imports in plugin.ts.

I've found one issue regarding the yarn.lock file which seems to be inconsistent with the package.json changes. Please see my comment on that file.

version: 0.0.0-use.local
resolution: "@graphql-hive/plugin-opentelemetry@workspace:packages/plugins/opentelemetry"
dependencies:
"@envelop/core": "npm:^5.4.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's an inconsistency between package.json and yarn.lock. The package.json for @graphql-hive/plugin-opentelemetry specifies a dependency on @envelop/core with version ^5.4.1, but the yarn.lock file lists it as npm:^5.4.0. This could lead to resolution issues or using an unintended version of the package.

Please run yarn install again to ensure the lock file is correctly updated to reflect the changes in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant