chore(opentelemetry): use standard withState util#1810
chore(opentelemetry): use standard withState util#1810EmrysMyrddin wants to merge 2 commits intomainfrom
withState util#1810Conversation
Summary of ChangesHello @EmrysMyrddin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the OpenTelemetry plugin by adopting the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the opentelemetry plugin to use the standard withState utility from @envelop/core instead of a custom implementation. This is a great improvement as it reduces code duplication and maintenance overhead. The changes are straightforward, with the removal of the local plugin-utils.ts file and updating the imports in plugin.ts.
I've found one issue regarding the yarn.lock file which seems to be inconsistent with the package.json changes. Please see my comment on that file.
| version: 0.0.0-use.local | ||
| resolution: "@graphql-hive/plugin-opentelemetry@workspace:packages/plugins/opentelemetry" | ||
| dependencies: | ||
| "@envelop/core": "npm:^5.4.0" |
There was a problem hiding this comment.
There's an inconsistency between package.json and yarn.lock. The package.json for @graphql-hive/plugin-opentelemetry specifies a dependency on @envelop/core with version ^5.4.1, but the yarn.lock file lists it as npm:^5.4.0. This could lead to resolution issues or using an unintended version of the package.
Please run yarn install again to ensure the lock file is correctly updated to reflect the changes in package.json.
No description provided.