Skip to content

chore(opentelemetry): use standard withState util #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmrysMyrddin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(opentelemetry): use standard withState util #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0cee20
chore(opentelemetry): use standard `withState` util
EmrysMyrddin Dec 18, 2025
69caded
chore(dependencies): updated changesets for modified dependencies
github-actions[bot] Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/@graphql-hive_plugin-opentelemetry-1810-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@graphql-hive/plugin-opentelemetry': patch
---

dependencies updates:

- Added dependency [`@envelop/core@^5.4.1` ↗︎](https://www.npmjs.com/package/@envelop/core/v/5.4.1) (to `dependencies`)
1 change: 1 addition & 0 deletions packages/plugins/opentelemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"graphql": "^15.9.0 || ^16.9.0"
},
"dependencies": {
"@envelop/core": "^5.4.1",
"@graphql-hive/core": "^0.18.0",
"@graphql-hive/gateway-runtime": "workspace:^",
"@graphql-hive/logger": "workspace:^",
Expand Down
171 changes: 0 additions & 171 deletions packages/plugins/opentelemetry/src/plugin-utils.ts
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions packages/plugins/opentelemetry/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
import {
getMostSpecificState,
withState,
type GatewayState,
type GraphQLState,
type HttpState,
} from '@envelop/core';
import {
GatewayConfigContext,
getRetryInfo,
Expand All @@ -20,13 +27,6 @@ import {
} from './api';
import { SEMATTRS_HIVE_REQUEST_ID } from './attributes';
import { OtelContextStack } from './context';
import {
getMostSpecificState,
withState,
type GatewayState,
type GraphQLState,
type HttpState,
} from './plugin-utils';
import {
createGraphqlContextBuildingSpan,
createGraphQLExecuteSpan,
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4414,6 +4414,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@graphql-hive/plugin-opentelemetry@workspace:packages/plugins/opentelemetry"
dependencies:
"@envelop/core": "npm:^5.4.0"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's an inconsistency between package.json and yarn.lock. The package.json for @graphql-hive/plugin-opentelemetry specifies a dependency on @envelop/core with version ^5.4.1, but the yarn.lock file lists it as npm:^5.4.0. This could lead to resolution issues or using an unintended version of the package.

Please run yarn install again to ensure the lock file is correctly updated to reflect the changes in package.json.

"@graphql-hive/core": "npm:^0.18.0"
"@graphql-hive/gateway-runtime": "workspace:^"
"@graphql-hive/logger": "workspace:^"
Expand Down
Loading