Open
Conversation
|
Thanks for your work, it helps a lot on our system. @sranka Cloud you help to merge it. |
jsternberg
suggested changes
Sep 19, 2025
Contributor
jsternberg
left a comment
jsternberg
left a comment
There was a problem hiding this comment.
I am no longer associated with this project and I think this repository isn't accepting PRs anyway at this point. This shows up in my review requests on GitHub and GitHub won't let me review it since I don't have permissions to the project anymore. I think this is the only way for me to remove myself from the review requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, it is unable to set transport for http.Client.
If many connections and fast run, there is problem with ever-increasing TIME_WAIT socket on a network.
Creating and derivering http.client pointer may be one way, but to minimize modifications of origin code i just add http.Transport config to client.HTTPConfig.
I think It allows to handle http.Client Transport configurations about Connections at least.