Skip to content

add configs to client.HTTPConfig #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zajann wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add configs to client.HTTPConfig #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37ddd19
add configs to client.HTTPConfig
zajann Jan 14, 2020
1d0b91d
Merge branch 'master' into master
zajann Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion v2/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,26 @@ type HTTPConfig struct {
// Proxy configures the Proxy function on the HTTP client.
Proxy func(req *http.Request) (*url.URL, error)

// DisableKeepAlives gets passed to the http client, if true, it will
// only use the connection to the server for a single HTTP Request
DisableKeepAlives bool

// MaxIdleConns gets passed to the http client, controls the maximum
// number of idle(keep-alive) connections across all hosts.
// Zero means no limit.
MaxIdleConns int

// MaxIdleConnsPerHost gets passed to the http client, if non-zero,
// controls the maximum idle (keep-alive) connections to keep per-host.
// If zero, DefaultMaxIdleConnsPerHost is used.
MaxIdleConnsPerHost int

// MaxConnsPerHost gets passed to the http client, if non-zero,
// limits the total number of connections per host, including connections
// in the dialing, active, and idle states.
// Zero means no limit.
MaxConnsPerHost int

// WriteEncoding specifies the encoding of write request
WriteEncoding ContentEncoding
}
Expand Down Expand Up @@ -123,7 +143,11 @@ func NewHTTPClient(conf HTTPConfig) (Client, error) {
TLSClientConfig: &tls.Config{
InsecureSkipVerify: conf.InsecureSkipVerify,
},
Proxy: conf.Proxy,
Proxy: conf.Proxy,
DisableKeepAlives: conf.DisableKeepAlives,
MaxIdleConns: conf.MaxIdleConns,
MaxIdleConnsPerHost: conf.MaxIdleConnsPerHost,
MaxConnsPerHost: conf.MaxConnsPerHost,
}
if conf.TLSConfig != nil {
tr.TLSClientConfig = conf.TLSConfig
Expand Down