Fix Gradle automated dependency updates for multi-module projects#1275
Open
Fix Gradle automated dependency updates for multi-module projects#1275
Conversation
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Collaborator
eranturgeman
left a comment
eranturgeman
left a comment
There was a problem hiding this comment.
Please see my comments and add explanation about what did you try to fix here
4 tasks
attiasas
reviewed
Apr 20, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Nice, check out my comments.
Don't forget to fix static analysis and tests
| return | ||
| } | ||
|
|
||
| func getAllGradleDescriptorFilesFullPaths() (descriptorFilesFullPaths []string, err error) { |
Contributor
There was a problem hiding this comment.
🟡 [API / contract design]
Document that Gradle descriptor discovery is now recursive (unlike GetAllDescriptorFilesFullPaths), and confirm this matches Frogbot’s execution model so we don’t double-fix or conflict with per-subproject scans.
Contributor
Author
There was a problem hiding this comment.
will be done with Talia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frogbot’s Gradle fix path only considered build.gradle / build.gradle.kts files in the repository root. In multi-module Gradle layouts, direct dependencies are often declared only in subproject build files, so fixes failed with errors such as “impacted package … was not found or could not be fixed in all descriptor files” even when those coordinates appeared in a submodule.
This change adds a recursive walk that collects Gradle descriptors across the tree, while skipping common non-source directories (for example .git, .gradle, build, node_modules, IDE folders).