fix: show ingestion error inline on failed Knowledge table rows - #2348
fix: show ingestion error inline on failed Knowledge table rows#2348Thenathanb wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe knowledge grid now shows ingestion error text in a tooltip and includes that text in the failed-row button’s accessible label. ChangesKnowledge error display
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to Failed Knowledge ingestion rows now expose their resolved error in an accessible label and hover tooltip while retaining the existing task-dialog action. No current merge-blocking risk remains. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| align="end" | ||
| className="max-w-80 whitespace-pre-wrap break-words" | ||
| > | ||
| {data.error} |
There was a problem hiding this comment.
Medium Issue
Resolve task errors before rendering the tooltip —
When a legacy/provider failure supplies wrapped JSON in fileInfo.error, TaskContext copies that raw value into data.error, whereas the Task dialog passes it through resolveTaskFileError and formatProviderErrorMessage. Rendering data.error directly therefore shows raw backend payloads instead of the resolved user-facing message promised by this change; apply the same resolution used by the dialog.
Hovering a failed row's status badge now shows the resolved error message as a tooltip, instead of requiring a click into the Task dialog just to see why ingestion failed. Clicking still opens the Task dialog as before.
7742464 to
581e743
Compare
Summary
Tooltipcomponent already used elsewhere in the same file (e.g. the filename column).Test plan
npm run typecheckpasses with no errorsnpm run lint(biome) shows no new warningsSummary by CodeRabbit