Skip to content

fix: show ingestion error inline on failed Knowledge table rows - #2348

Open
Thenathanb wants to merge 2 commits into
langflow-ai:mainfrom
Thenathanb:knowledge-table-inline-error-tooltip
Open

fix: show ingestion error inline on failed Knowledge table rows#2348
Thenathanb wants to merge 2 commits into
langflow-ai:mainfrom
Thenathanb:knowledge-table-inline-error-tooltip

Conversation

@Thenathanb

@Thenathanb Thenathanb commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Hovering a failed row's status badge in the Knowledge table now shows a tooltip with the resolved ingestion error message, instead of requiring a click into the Task dialog just to see why a file failed.
  • Clicking the badge still opens the Task dialog exactly as before — no change to that behavior.
  • Reuses the existing Tooltip component already used elsewhere in the same file (e.g. the filename column).

Test plan

  • npm run typecheck passes with no errors
  • npm run lint (biome) shows no new warnings
  • Manually verified in the browser: uploaded a corrupted PDF, confirmed the failed row shows a tooltip with the full Docling error message on hover, wraps correctly instead of overflowing, and clicking still opens the Task dialog

Summary by CodeRabbit

  • Bug Fixes
    • Knowledge grid ingestion failures now display the associated error message in a tooltip when hovering over the error action.
    • Error action accessibility labels now include the relevant ingestion error when available.

@github-actions github-actions Bot added community frontend 🟨 Issues related to the UI/UX and removed community labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 88b71bf4-4ad3-46b4-83f0-fc32d740536e

📥 Commits

Reviewing files that changed from the base of the PR and between 452f69b and 7742464.

📒 Files selected for processing (1)
  • frontend/app/knowledge/page.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The knowledge grid now shows ingestion error text in a tooltip and includes that text in the failed-row button’s accessible label.

Changes

Knowledge error display

Layer / File(s) Summary
Failed status error details
frontend/app/knowledge/page.tsx
The failed-status renderer stores the button in a local variable. The button label includes the error message when available. Rows with errors wrap the button in a tooltip; other rows render the button directly.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 77424

Failed Knowledge ingestion rows now expose their resolved error in an accessible label and hover tooltip while retaining the existing task-dialog action. No current merge-blocking risk remains.

Suggested labels: enhancement

Suggested reviewers: mfortman11, edwinjosechittilappilly, jason-dong03

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: showing ingestion errors inline on failed Knowledge table rows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mfortman11
mfortman11 self-requested a review September 9, 2026 21:42
align="end"
className="max-w-80 whitespace-pre-wrap break-words"
>
{data.error}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium Issue
Resolve task errors before rendering the tooltip —

When a legacy/provider failure supplies wrapped JSON in fileInfo.error, TaskContext copies that raw value into data.error, whereas the Task dialog passes it through resolveTaskFileError and formatProviderErrorMessage. Rendering data.error directly therefore shows raw backend payloads instead of the resolved user-facing message promised by this change; apply the same resolution used by the dialog.

Hovering a failed row's status badge now shows the resolved error
message as a tooltip, instead of requiring a click into the Task
dialog just to see why ingestion failed. Clicking still opens the
Task dialog as before.
@Thenathanb
Thenathanb force-pushed the knowledge-table-inline-error-tooltip branch from 7742464 to 581e743 Compare September 9, 2026 23:53
@Thenathanb Thenathanb changed the title Show ingestion error inline on failed Knowledge table rows fix: show ingestion error inline on failed Knowledge table rows Sep 9, 2026
@github-actions github-actions Bot added the bug 🔴 Something isn't working. label Sep 9, 2026
@github-actions github-actions Bot added bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants